Skip to content

Fix #7407: Synthesise a quote context only for macros #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@anatoliykmetyuk anatoliykmetyuk changed the title Fix #7407 – Synthesise a quote context only for macros Fix #7407: Synthesise a quote context only for macros Oct 14, 2019
There was an error in that test where you need a QuoteContext
in scope to write quotes. The error did not manifest itself since
a synthetic QuoteContext was generated for all inline methods
from which it was required (disregarding whether they are meant as
macro implementations or not). This behavior was wrong, however,
(see scala#7407) and hence this test needs fixing.
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 42e3ad4 into scala:master Oct 15, 2019
@liufengyun liufengyun deleted the i7407 branch October 15, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants